[webkit-reviews] review denied: [Bug 113168] LayoutTests/fast/js/large-expressions.html crashes on Linux : [Attachment 196980] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 10 02:37:41 PDT 2013
Allan Sandfeld Jensen <allan.jensen at digia.com> has denied linzj
<manjian2006 at gmail.com>'s request for review:
Bug 113168: LayoutTests/fast/js/large-expressions.html crashes on Linux
https://bugs.webkit.org/show_bug.cgi?id=113168
Attachment 196980: patch
https://bugs.webkit.org/attachment.cgi?id=196980&action=review
------- Additional Comments from Allan Sandfeld Jensen <allan.jensen at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196980&action=review
> Source/WTF/wtf/StackBounds.cpp:158
> m_bound = stackBase;
> m_origin = static_cast<char*>(stackBase) + stackSize;
m_bound = stackBase + guardSize
m_origin = stackBase + guardSize + stackSize
> Source/WTF/wtf/StackBounds.cpp:165
> + m_bound = reinterpret_cast<char*>(m_bound) + guardSize;
> + stackSize -= guardSize;
m_origin = static_cast<char*>(m_origin) - guardSize;
More information about the webkit-reviews
mailing list