[webkit-reviews] review denied: [Bug 112418] FrameLoaderClient::assignIdentifierToInitialRequest() not called for the main resource when loaded from the memory cache : [Attachment 197000] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 112418: FrameLoaderClient::assignIdentifierToInitialRequest() not called
for the main resource when loaded from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=112418

Attachment 197000: Patch
https://bugs.webkit.org/attachment.cgi?id=197000&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Thanks for following up with a test.

This might sound like a silly nit pick, but it will help avoid confusion in the
future:  The test name and text sounds too much like it is referring to the
page cache, when we're really talking about the resource cache.

Anywhere you mention "cached page" can you please mention "cached main
resource" instead?