[webkit-reviews] review granted: [Bug 114048] [EFL] --minimal build fails with error:=?UTF-8?Q?=20=E2=80=98ViewModeInvalid=E2=80=99=20is=20not=20a=20member=20of=20=E2=80=98WebCore?=::=?UTF-8?Q?Page=E2=80=99=20?=: [Attachment 196810] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 9 19:38:27 PDT 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ed Bartosh
<bartosh at gmail.com>'s request for review:
Bug 114048: [EFL] --minimal build fails with error: ‘ViewModeInvalid’ is not a
member of ‘WebCore::Page’
https://bugs.webkit.org/show_bug.cgi?id=114048

Attachment 196810: Patch
https://bugs.webkit.org/attachment.cgi?id=196810&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196810&action=review


LGTM otherwise.

> Source/WebKit/efl/ewk/ewk_view.cpp:4258
> +#if ENABLE(VIEW_MODE_CSS_MEDIA)

Move macro to inside function in public APIs case.

> Source/WebKit/efl/ewk/ewk_view.cpp:-4262
> -

Do not touch code unrelated to this patch.


More information about the webkit-reviews mailing list