[webkit-reviews] review granted: [Bug 114323] TileController doesn't remove tiles when the view is resized, leading to stale content : [Attachment 197194] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 9 18:11:03 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 114323: TileController doesn't remove tiles when the view is resized,
leading to stale content
https://bugs.webkit.org/show_bug.cgi?id=114323

Attachment 197194: patch
https://bugs.webkit.org/attachment.cgi?id=197194&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197194&action=review


> Source/WebCore/platform/graphics/ca/mac/TileController.mm:736
> +	       if (it->key.y() < topLeftForBounds.y()
> +		   || it->key.y() > bottomRightForBounds.y()
> +		   || it->key.x() < topLeftForBounds.x()
> +		   || it->key.x() > bottomRightForBounds.x())

Would be cleaner if you copied it->key into a TileIndex variable.


More information about the webkit-reviews mailing list