[webkit-reviews] review granted: [Bug 114322] Update Document's event listener type bitfield when adopting a Node : [Attachment 197189] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 114322: Update Document's event listener type bitfield when adopting a Node
https://bugs.webkit.org/show_bug.cgi?id=114322

Attachment 197189: Patch
https://bugs.webkit.org/attachment.cgi?id=197189&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197189&action=review


Looks fine.

> Source/WebCore/dom/Node.cpp:2158
> +	       Vector<AtomicString> types = listenerMap.eventTypes();

If I had more time I’d study the implementation of
EventListenerMap::eventTypes, but is it really necessary to copy a vector of
atomic strings? Is there any more efficient way to get at the event type
strings, perhaps without allocating memory?