[webkit-reviews] review denied: [Bug 114240] Hopefully helpful comments for some String methods : [Attachment 197003] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 9 12:52:38 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied Victor Costan
<costan at gmail.com>'s request for review:
Bug 114240: Hopefully helpful comments for some String methods
https://bugs.webkit.org/show_bug.cgi?id=114240

Attachment 197003: Patch
https://bugs.webkit.org/attachment.cgi?id=197003&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
I am okay with adding comments in wtf. I think it would be great.

Contrarily to WebCore, WTF does not change as fast but it is used by every code
out there.

But I think we need proper usage documentation instead of comments here and
there.


More information about the webkit-reviews mailing list