[webkit-reviews] review granted: [Bug 17705] Whitespace between nowrap elements ignored after collapsed trailing space in a text run : [Attachment 191544] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 17705: Whitespace between nowrap elements ignored after collapsed trailing
space in a text run
https://bugs.webkit.org/show_bug.cgi?id=17705

Attachment 191544: Patch
https://bugs.webkit.org/attachment.cgi?id=191544&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191544&action=review


> Source/WebCore/rendering/RenderBlockLineLayout.cpp:3081
> +		       // If we allow whitespace collapsing 'word  ' and 'word'
are equivalent when before a whitespace
> +		       // character, so treat both as a potential linebreak.

Nit: I would insert a comma after "If we allow whitespace collapsing" and get
rid of "when" in "when before a whitespace".

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:3082
> +		       checkForBreak = (ignoringSpaces ||
!currentCharacterIsSpace) && (c == ' ' || c == '\t' || (c == '\n' &&
!next->preservesNewline()));

We should extract c == ' ' || c == '\t' || (c == '\n' &&
!next->preservesNewline() as a helper function at some point.

> LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-5.html:20
> +    <span class="nowrap">xx	</span> 
> +    <span class="nowrap">xx</span>

Please add a test case for bidirectional text.