[webkit-reviews] review granted: [Bug 110372] [CSS Exclusions] Properly position multiple stacked floats with non rectangular shape outside : [Attachment 196877] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 110372: [CSS Exclusions] Properly position multiple stacked floats with non
rectangular shape outside
https://bugs.webkit.org/show_bug.cgi?id=110372

Attachment 196877: Patch
https://bugs.webkit.org/attachment.cgi?id=196877&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196877&action=review


> Source/WebCore/ChangeLog:22
> +	   (WebCore::RenderBlock::logicalRightOffsetForLine): Add paramter for
offset mode.

Typo: parameter

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:202
> +    RenderBlock::FloatingObjectSetIterator it = floatingObjectSet.end();
> +    --it; // Go to last item.
> +    RenderBlock::FloatingObjectSetIterator begin =
floatingObjectSet.begin();
> +    while (it != begin) {
> +	   --it;

Doesn't this skip the very last item in the first pass? Is that ok?