[webkit-reviews] review granted: [Bug 114228] [webkitpy] Remove chromium deprecated port support : [Attachment 197140] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 9 11:26:48 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Glenn Adams <glenn at skynav.com>'s
request for review:
Bug 114228: [webkitpy] Remove chromium deprecated port support
https://bugs.webkit.org/show_bug.cgi?id=114228

Attachment 197140: Patch
https://bugs.webkit.org/attachment.cgi?id=197140&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=197140&action=review


>>> Tools/ChangeLog:3
>>> +	     [webkitpy] Remove chromium port support.
>> 
>> You’re just removing the deprecated ports. There are also non-deprecated
ports in layout_tests/ports/
> 
> Correct. I wanted to do this one step at a time to partition potential
regression and test-webkitpy impact.

Please be sure to update the change log before you land it.


More information about the webkit-reviews mailing list