[webkit-reviews] review granted: [Bug 113817] AX: Bounding paths should be made available through accessibility : [Attachment 196718] patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 113817: AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817

Attachment 196718: patch
https://bugs.webkit.org/attachment.cgi?id=196718&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196718&action=review


r=me, but please investigate why there is a "Move to point" after "Close" on
the mac/accessibility/element-paths-expected.txt test results, and future-proof
the #if in AccessibilityUIElement.cpp

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:1094
> +#if !PLATFORM(MAC)
> +JSStringRef AccessibilityUIElement::pathDescription() const { return 0; }
> +#endif

For future-proofing, this should be:

#if !PLATFORM(IOS) && !PLATFORM(MAC)

> LayoutTests/platform/mac/accessibility/element-paths-expected.txt:14
> +PASS svg.isAttributeSupported('AXPath') is true
> +SVG path description
> +Start Path
> +	Move to point
> +	Line to
> +	Line to
> +	Close
> +	Move to point

Would it be better to print out the point and line data here?  Or will that
change from Mac-to-Mac?

Why is there a "Move to point" after "Close" here and on the two tests below?

>
LayoutTests/platform/iphone-simulator/accessibility/element-paths-expected.txt:
12
> +SVG path description
> +Start Path
> +	Move to point
> +	Line to
> +	Line to
> +	Close

Would it be best to have specific point and line information here?