[webkit-reviews] review granted: [Bug 86700] Showing error message when CachedFont::ensureCustomFontData() fails : [Attachment 157575] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 86700: Showing error message when CachedFont::ensureCustomFontData() fails
https://bugs.webkit.org/show_bug.cgi?id=86700

Attachment 157575: Patch
https://bugs.webkit.org/attachment.cgi?id=157575&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157575&action=review


> Source/WebCore/css/CSSFontFaceSource.cpp:168
> +			  
fontSelector->document()->addConsoleMessage(NetworkMessageSource,
LogMessageType, ErrorMessageLevel, "Cannot use the font.", m_string);

Seems like a good idea, but generally seems like too vague a message. This
would be much better with a message that cites the URL for the font.