[webkit-reviews] review granted: [Bug 113846] [Mac] REGRESSION: Autocorrection doesn't work in DumpRenderTree : [Attachment 196988] Fixes DRT and improves tests

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 113846: [Mac] REGRESSION: Autocorrection doesn't work in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113846

Attachment 196988: Fixes DRT and improves tests
https://bugs.webkit.org/attachment.cgi?id=196988&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196988&action=review


r=me since the change looks correct, however:

> NSTextCheckingTypeSpelling instead of NSTextCheckingTypeCorrection

How does this patch fix what's in bug description?

> LayoutTests/ChangeLog:8
> +	   Remoevd failing expectations from tests that require "mesage" to be
corrected to "message".

Typo: "Remoeved".

> LayoutTests/ChangeLog:10
> +	   without pixel results (we still dump pixel results to sanity check).


Is this what dumpAsText(true) does? In such case, we need a more descriptive
way to express this desire.