[webkit-reviews] review granted: [Bug 114226] Don't try to remove a non-existent snapshot : [Attachment 196975] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 8 17:47:18 PDT 2013


Darin Adler <darin at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 114226: Don't try to remove a non-existent snapshot
https://bugs.webkit.org/show_bug.cgi?id=114226

Attachment 196975: Patch
https://bugs.webkit.org/attachment.cgi?id=196975&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196975&action=review


> Source/WebCore/html/HTMLPlugInImageElement.cpp:96
> +    DisplayState previousDisplayState = displayState();

This line of code needs to be inside the same #if as the code below; #if
PLATFORM(MAC), although I wish that was not the way we guarded this feature!
Please fix that before landing.


More information about the webkit-reviews mailing list