[webkit-reviews] review granted: [Bug 114225] Repaint rect too small on elements with shadows : [Attachment 196973] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 114225: Repaint rect too small on elements with shadows
https://bugs.webkit.org/show_bug.cgi?id=114225

Attachment 196973: Patch
https://bugs.webkit.org/attachment.cgi?id=196973&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196973&action=review


Would have been nice to have the rename of blur to radius in a first, separate
patch.

> Source/WebCore/rendering/style/ShadowData.h:77
> +    int paintingExtent() const
> +    {
> +	   const float radiusExtentMultplier = 1.3;
> +	   return ceilf(m_radius * radiusExtentMultplier);
> +    };

Needs a comment to explain why 1.3 is a correct, helpful value.

Typo: Multplier.

Extraneous semicolon here.

The name “extent” is a strange word for a scalar that represents the amount to
inflate a dirty rect with. It’s related to the extent of the shadow, but the
number itself does not seem to be an extent. Is there some other word that
would be more accurate for this concept?