[webkit-reviews] review granted: [Bug 104807] Adds support for fromCharCode intrinsic : [Attachment 196964] FromCharCode Fixed patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Vahag <vaag at ispras.ru>'s request for
review:
Bug 104807: Adds support for fromCharCode intrinsic
https://bugs.webkit.org/show_bug.cgi?id=104807

Attachment 196964: FromCharCode Fixed patch
https://bugs.webkit.org/attachment.cgi?id=196964&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196964&action=review


LGTM other than the minor fixes.  Marking r+/cq-; I'll cq+ the patch with those
minor fixes.

> Source/JavaScriptCore/dfg/DFGOperations.cpp:1593
> +

Unnecessary white space.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2100
> +    JITCompiler::JumpList isNotASCIICharacter;

Rename this to just slowCase or slowPath, since it's no longer about whether or
not the input is an ASCII character.