[webkit-reviews] review granted: [Bug 113912] [GTK][AC] Adding contentsLayer for image and video : [Attachment 196648] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Joone Hur
<joone at webkit.org>'s request for review:
Bug 113912: [GTK][AC] Adding contentsLayer for image and video
https://bugs.webkit.org/show_bug.cgi?id=113912

Attachment 196648: Patch
https://bugs.webkit.org/attachment.cgi?id=196648&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196648&action=review


> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:743
> +#ifndef NDEBUG
> +	       clutter_actor_set_name(CLUTTER_ACTOR(m_contentsLayer.get()),
"Image Layer");
> +#endif

I think we should set the name regardless of debug mode, it's not like this
adds any overhead, right?

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.h:220
> +    // FIXME: Need to use RetainPtr

This FIXME makes no sense.