[webkit-reviews] review denied: [Bug 104807] Adds support for fromCharCode intrinsic : [Attachment 196957] Adds Support for fromCharCode intrinsic

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Vahag <vaag at ispras.ru>'s request for
review:
Bug 104807: Adds support for fromCharCode intrinsic
https://bugs.webkit.org/show_bug.cgi?id=104807

Attachment 196957: Adds Support for fromCharCode intrinsic 
https://bugs.webkit.org/attachment.cgi?id=196957&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196957&action=review


LGTM except for those minor fixes.

> Source/JavaScriptCore/dfg/DFGAbstractState.cpp:865
> +	   node->setCanExit(true);

Not needed.

> Source/JavaScriptCore/dfg/DFGAbstractState.cpp:866
> +	   forNode(node->child1()).filter(SpecInt32);

Not needed.

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:352
> +	       setUseKindAndUnboxIfProfitable<Int32Use>(node->child1());

The reason why you don't need the filter() and setCanExit() in AbstractState is
that AbstractState::executeEdges() takes care of this based on Int32Use.