[webkit-reviews] review granted: [Bug 109709] wtf/dtoa/* uses a confusing name to reference its buffers : [Attachment 189627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 8 10:25:54 PDT 2013


Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 109709: wtf/dtoa/* uses a confusing name to reference its buffers
https://bugs.webkit.org/show_bug.cgi?id=109709

Attachment 189627: Patch
https://bugs.webkit.org/attachment.cgi?id=189627&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189627&action=review


>> Source/WTF/wtf/dtoa/utils.h:140
>> -	// This is a simplified version of V8's Vector class.
>> +	// This is a simplified version of V8's BufferReference class.
> 
> Probably want to fix this comment now.

Let me amplify what Eric said. This comment makes no sense like this. Please
fix it before landing.


More information about the webkit-reviews mailing list