[webkit-reviews] review granted: [Bug 113132] [GTK] DOM objects created wrapping a base class have incorrect GObject type : [Attachment 194712] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 113132: [GTK] DOM objects created wrapping a base class have incorrect
GObject type
https://bugs.webkit.org/show_bug.cgi?id=113132

Attachment 194712: Patch
https://bugs.webkit.org/attachment.cgi?id=194712&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194712&action=review


Makes sense to me.

> Source/WebCore/bindings/gobject/WebKitDOMEventTargetPrivate.h:30
> +WebKitDOMEventTarget* wrapEventTarget(WebCore::EventTarget*);

This doesn't seem to exist after the changes. Leftover?

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1276
>      my $lowerCaseIfaceName = "webkit_dom_" .
FixUpDecamelizedName(decamelize($interfaceName));
>      my $parentImplClassName = GetParentImplClassName($interface);
> +    my $baseClass = GetBaseClass($parentImplClassName);

Nit: all the other variables have the 'Name' suffix, so it makes sense to keep
the convention here.