[webkit-reviews] review canceled: [Bug 110743] [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess() : [Attachment 196821] Do all cleanup on terminate (both WebPageProxy and WebProcessProxy).

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 8 05:48:13 PDT 2013


Adenilson Cavalcanti Silva <savagobr at yahoo.com> has canceled Adenilson
Cavalcanti Silva <savagobr at yahoo.com>'s request for review:
Bug 110743: [WK2] WebPageProxy loadURL() won't work when called just after
terminateProcess()
https://bugs.webkit.org/show_bug.cgi?id=110743

Attachment 196821: Do all cleanup on terminate (both WebPageProxy and
WebProcessProxy).
https://bugs.webkit.org/attachment.cgi?id=196821&action=review

------- Additional Comments from Adenilson Cavalcanti Silva
<savagobr at yahoo.com>
WebProcess termination now is done using a new function
'userRequestedTerminate' that performs complete shutdown of WebProcessProxy
before returning. This ensures that at time reattachToWebProcess() is executed,
WebProcessProxy is in a sane state.
    
Next, cleanup of WebPageProxy is done at terminateProcess(), using a new
function named 'processTeardown()', that is shared with processDidCrash().
Finally, client is not notified of process crash, since it was terminated per
client's request.
    
This changes makes the new test succeed, but will cause a regression in all
tests that depend on a callback to be executed at process termination.


More information about the webkit-reviews mailing list