[webkit-reviews] review denied: [Bug 113853] Add API in QWebSettings for setting the CSS media type : [Attachment 196455] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Jose Lejin PJ
<jose.lejin at gmail.com>'s request for review:
Bug 113853: Add API in QWebSettings for setting the CSS media type
https://bugs.webkit.org/show_bug.cgi?id=113853

Attachment 196455: Patch
https://bugs.webkit.org/attachment.cgi?id=196455&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
Did you test this well?
By reading the code it seems like this only applies to the current FrameView
(which is only used for the currently navigated page).
If you click a link to navigate to a second page, it feels like this setting
won't be applied unless you call setMediaTypeOverride again.

A safer way to implement this would be to do like setMediaStyle is implemented
in Source/WebKit/mac/WebView/WebView.mm.
It could still live in QWebSettings, but instead of forwarding the value to
WebCore::Settings, it would be fetched by our implementation of
FrameLoaderClientQt::overrideMediaType in
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp.