[webkit-reviews] review requested: [Bug 94316] [GTK] Add webkit_uri_scheme_request_finish_error : [Attachment 196839] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 8 01:29:20 PDT 2013


Manuel Rego Casasnovas <rego at igalia.com> has asked  for review:
Bug 94316: [GTK] Add webkit_uri_scheme_request_finish_error
https://bugs.webkit.org/show_bug.cgi?id=94316

Attachment 196839: Patch
https://bugs.webkit.org/attachment.cgi?id=196839&action=review

------- Additional Comments from Manuel Rego Casasnovas <rego at igalia.com>
While adding the check for the error domain I realized that the error always
have G_IO_ERROR domain, this was because of the implementation of
ResourceError::httpError(). I've did a change to keep the domain of the error,
but maybe that's not right.


More information about the webkit-reviews mailing list