[webkit-reviews] review granted: [Bug 114105] Make Frame's ScriptController an OwnPtr and remove the #include : [Attachment 196761] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 7 23:04:23 PDT 2013


Daniel Bates <dbates at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 114105: Make Frame's ScriptController an OwnPtr and remove the #include
https://bugs.webkit.org/show_bug.cgi?id=114105

Attachment 196761: Patch
https://bugs.webkit.org/attachment.cgi?id=196761&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Nice!

As implied by the EFL and GTK EWS error output, you'll need to include the
header Document.h in file Source/WebCore/editing/atk/FrameSelectionAtk.cpp
because you removed the include header ScriptController.h from file
Source/WebCore/page/Frame.h.

Additionally, you'll need to include the header ScriptController.h in file
Source/WebKit/qt/Api/qwebelement.cpp as implied by the error output from the
Qt- and Qt-WK2- EWS bots.


More information about the webkit-reviews mailing list