[webkit-reviews] review granted: [Bug 114132] [WIN] Fix problems with export macros of AutodrainedPool : [Attachment 196814] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 7 15:48:16 PDT 2013
Geoffrey Garen <ggaren at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 114132: [WIN] Fix problems with export macros of AutodrainedPool
https://bugs.webkit.org/show_bug.cgi?id=114132
Attachment 196814: Patch
https://bugs.webkit.org/attachment.cgi?id=196814&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196814&action=review
Please fix the style comment below before landing.
> Source/WTF/wtf/AutodrainedPool.h:49
> + inline explicit AutodrainedPool(int = 1) { }
> + inline ~AutodrainedPool() { }
> + inline void cycle() { }
No need for the inline keyword when defining a function inside its class
declaration -- inline is implied.
More information about the webkit-reviews
mailing list