[webkit-reviews] review granted: [Bug 114081] Remove remaining PLATFORM(CHROMIUM)-guarded code in WebCore : [Attachment 196812] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 114081: Remove remaining PLATFORM(CHROMIUM)-guarded code in WebCore
https://bugs.webkit.org/show_bug.cgi?id=114081

Attachment 196812: Patch
https://bugs.webkit.org/attachment.cgi?id=196812&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196812&action=review


Brilliant!

> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:181
> +#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(EFL) || PLATFORM(BLACKBERRY)
|| PLATFORM(WIN)

I wonder if that should be a
    #if !PLATFORM(QT)

(in a separate patch).

> Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:38
>  #include "Logging.h"
> +#include "NotImplemented.h"
>  #include <helpers/memenv/memenv.h>

??