[webkit-reviews] review granted: [Bug 114110] Do not allocate static AtomicStrings when searching for alternate font names : [Attachment 196769] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 7 12:40:18 PDT 2013


Geoffrey Garen <ggaren at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 114110: Do not allocate static AtomicStrings when searching for alternate
font names
https://bugs.webkit.org/show_bug.cgi?id=114110

Attachment 196769: Patch
https://bugs.webkit.org/attachment.cgi?id=196769&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196769&action=review


r=me

> Source/WebCore/ChangeLog:25
> +	   To avoid comparing the input to every string, every time, the lenght
of

Typo: length.

> Source/WebCore/platform/graphics/FontCache.cpp:156
> +    // Alias Arial and Helvetica

Typo: Needs a ".".


More information about the webkit-reviews mailing list