[webkit-reviews] review granted: [Bug 114075] Returning NULL from willSendRequest should cancel a load from the memory cache : [Attachment 196709] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 114075: Returning NULL from willSendRequest should cancel a load from the
memory cache
https://bugs.webkit.org/show_bug.cgi?id=114075

Attachment 196709: Patch
https://bugs.webkit.org/attachment.cgi?id=196709&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196709&action=review


> Source/WebCore/loader/cache/CachedResourceLoader.h:156
> +    bool shouldContinueAfterNotifyingLoadedFromMemoryCache(CachedResource*);


I might have suggested using a bool out argument instead of return value. Then
you would not have had to change the function name. But probably OK this way.

> LayoutTests/fast/loader/resources/cached-image.html:3
> +	   testRunner.setWillSendRequestReturnsNull(true);

Strange that this is a function call rather than a property.

> LayoutTests/fast/loader/resources/cached-image.html:5
> +<img src="compass.jpg" onload="console.log('FAIL: image was incorrectly
loaded')">

Do we really need a new image for this? Can’t we use an existing image that’s
already somewhere in the test tree?