[webkit-reviews] review granted: [Bug 112508] Modernize fast/events/autoscroll.html : [Attachment 193450] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 112508: Modernize fast/events/autoscroll.html
https://bugs.webkit.org/show_bug.cgi?id=112508

Attachment 193450: Patch
https://bugs.webkit.org/attachment.cgi?id=193450&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193450&action=review


Looks good!  Small nit, which may not be worth picking:

> LayoutTests/fast/events/no-scroll-on-input-text-selection.html:29
> +		       var h = ta.offsetTop - document.body.scrollTop + 10;
> +		       eventSender.dragMode = false;
> +		       eventSender.mouseMoveTo(20, h);
> +		       eventSender.mouseDown();
> +		       eventSender.mouseMoveTo(20, h);
> +		       eventSender.mouseMoveTo(100, h);

Nit: these all seem a little magic numbery.  There is some code in
LayoutTests/media/media-controls.js to find the mid-point of a specified
control.  That may be useful here for this selection test.