[webkit-reviews] review denied: [Bug 113862] Negative zero checks cause unnecessary speculation failures on SunSpider math-spectral-norm on ARMv7 : [Attachment 196312] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 5 12:10:42 PDT 2013
Filip Pizlo <fpizlo at apple.com> has denied Roman Zhuykov <zhroma at ispras.ru>'s
request for review:
Bug 113862: Negative zero checks cause unnecessary speculation failures on
SunSpider math-spectral-norm on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=113862
Attachment 196312: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=196312&action=review
------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
This looks good. But, I am withholding r+ until you add layout tests for the
cases where we generated incorrect code.
More information about the webkit-reviews
mailing list