[webkit-reviews] review granted: [Bug 113294] REGRESSION(r145279): Build fails while linking when MEDIA_STREAM is enabled : [Attachment 195131] Try to fix qt build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 5 02:01:15 PDT 2013


Xan Lopez <xan.lopez at gmail.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 113294: REGRESSION(r145279): Build fails while linking when MEDIA_STREAM is
enabled
https://bugs.webkit.org/show_bug.cgi?id=113294

Attachment 195131: Try to fix qt build
https://bugs.webkit.org/attachment.cgi?id=195131&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Since this is a build fix I think it makes sense to push it now. I agree that
possibly the bindings generator should cope with this somehow (but I'm not an
expert, so perhaps there are good reasons for this), but we can fix it after
this patch lands. Also a BlackBerry EWS/buildbot is planned, so we should be
able to catch this stuff in the near future.


More information about the webkit-reviews mailing list