[webkit-reviews] review granted: [Bug 113991] Web Inspector: crash in InspectorDOMAgent::innerHighlightQuad after r147566 : [Attachment 196571] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 5 01:25:56 PDT 2013


Joseph Pecoraro <joepeck at webkit.org> has granted Seokju Kwon
<seokju.kwon at gmail.com>'s request for review:
Bug 113991: Web Inspector: crash in InspectorDOMAgent::innerHighlightQuad after
r147566
https://bugs.webkit.org/show_bug.cgi?id=113991

Attachment 196571: Patch
https://bugs.webkit.org/attachment.cgi?id=196571&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196571&action=review


This looked suspicious to me in earlier previous patch, but I wasn't the
reviewer there. This looks good to me. r=me

> Source/WebCore/ChangeLog:8
> +	   No new tests, covered by existing tests.

Covered by existing tests? Which test is crashing? Call it out directly. If
there is no test, remove this line.


More information about the webkit-reviews mailing list