[webkit-reviews] review granted: [Bug 113754] Remove code for 10.5 and earlier from Source/WebCore : [Attachment 196275] Cleanup

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 113754: Remove code for 10.5 and earlier from Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=113754

Attachment 196275: Cleanup
https://bugs.webkit.org/attachment.cgi?id=196275&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196275&action=review


Looks great!

> Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp:119
> -    cgFontRef.adoptCF(CGFontCreateWithDataProvider(dataProvider.get()));
> +    RetainPtr<CGFontRef> cgFontRef =
adoptCF(CGFontCreateWithDataProvider(dataProvider.get()));

RetainPtr<CGFontRef> cgFontRef(AdoptCF,
CGFontCreateWithDataProvider(dataProvider.get())); ?

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1009
>	   initialSize.width = naturalSize.width;
>	   initialSize.height = naturalSize.height;
>      }

Not sure why this is not
    initialSize = naturalSize;

But that's unrelated :)

> Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm:372
> +

I would remove that blank line. The object is initialized in the following
lines.