[webkit-reviews] review denied: [Bug 113954] Regression(r147639) Causes assertion hit in HashTable : [Attachment 196550] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 113954: Regression(r147639) Causes assertion hit in HashTable
https://bugs.webkit.org/show_bug.cgi?id=113954

Attachment 196550: Patch
https://bugs.webkit.org/attachment.cgi?id=196550&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
This is correct. But you are slowing down the common case.

Now, you always need 2 table lookup on insertion.

If fontPlatformData() returns something, you should not need a second table
lookup, you should just put the value in the bucket you got with the first
table lookup.

It is okay (and the correct thing to do) to have the table lookup again if you
use alternateName. But if you don't, you should not have to pay the price for
it.