[webkit-reviews] review granted: [Bug 113958] Add SPI to get a copy of the context menu at a given point. : [Attachment 196525] Patch v1 - First swipe

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 113958: Add SPI to get a copy of the context menu at a given point.
https://bugs.webkit.org/show_bug.cgi?id=113958

Attachment 196525: Patch v1 - First swipe
https://bugs.webkit.org/attachment.cgi?id=196525&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196525&action=review


r=me with a comment

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:81
> +WK_EXPORT WKArrayRef WKBundlePageCopyContextMenuAtPoint(WKBundlePageRef,
WKPoint);

We should be clear what coordinate space we expect the point to be in, since
your code in WebPage::contextMenuAtPoint() creates a mouse event assuming
screen coordinate space. We decided on
WKBundlePageCopyContextMenuAtPointOnScreen() over IRC.