[webkit-reviews] review granted: [Bug 113952] Exception stack unwinding doesn't handle inline callframes correctly : [Attachment 196519] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 113952: Exception stack unwinding doesn't handle inline callframes
correctly
https://bugs.webkit.org/show_bug.cgi?id=113952

Attachment 196519: Patch
https://bugs.webkit.org/attachment.cgi?id=196519&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196519&action=review


r=me

> Source/JavaScriptCore/ChangeLog:15
> +	   This used to be safe as the exception handling machinery was
> +	   designed to fail gently and just claim that no handler existed.
> +	   This was "safe" and even "correct" inasmuch as we currently
> +	   don't run any code with exception handlers through the dfg.

So, why did it turn out not to be safe or correct?

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:2734
> +    while (InlineCallFrame* icf = origin.inlineCallFrame) {

Let's call this "inlineCallFrame".