[webkit-reviews] review granted: [Bug 112239] LLint should be able to use x87 instead of SSE for floating point : [Attachment 196457] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 4 13:52:29 PDT 2013


Filip Pizlo <fpizlo at apple.com> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 112239: LLint should be able to use x87 instead of SSE for floating point
https://bugs.webkit.org/show_bug.cgi?id=112239

Attachment 196457: Patch
https://bugs.webkit.org/attachment.cgi?id=196457&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
I like this!  Based on looking at the code, R=me.  Could you do me a favor
though: could you (a) upload your LLIntAssembly.h file so I could sanity check
it, mostly for my own curiosity; and (b) make sure that you run full
LayoutTests with JIT runtime disabled (put useJIT() = false into Options.cpp's
Options::initialize()) and make sure all is cool?


More information about the webkit-reviews mailing list