[webkit-reviews] review granted: [Bug 113420] Regression(r142765) Broke Custom SVG cursors and SVG canvas drawing for Chromium : [Attachment 196448] Patch

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 113420: Regression(r142765) Broke Custom SVG cursors and SVG canvas drawing
for Chromium
https://bugs.webkit.org/show_bug.cgi?id=113420

Attachment 196448: Patch
https://bugs.webkit.org/attachment.cgi?id=196448&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196448&action=review


Looks great.  The rest are just nits; we can do the copyImage() refactor in
another patch if you like.  r=me

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:273
> +    const SkBitmap& bitmap = *m_data.m_platformContext.bitmap();
> +    RefPtr<Image> image =
BitmapImage::create(NativeImageSkia::create(drawNeedsCopy(m_context.get(),
context) ? deepSkBitmapCopy(bitmap) : bitmap));

Nit:  I think this could now simply call
ImageBuffer::copyImage(drawNeedsCopy(m_context.get(), context)), no?

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:281
> +    const SkBitmap& bitmap = *m_data.m_platformContext.bitmap();
> +    RefPtr<Image> image =
BitmapImage::create(NativeImageSkia::create(drawNeedsCopy(m_context.get(),
context) ? deepSkBitmapCopy(bitmap) : bitmap));

Same here.

> Source/WebCore/platform/graphics/skia/NativeImageSkia.h:53
> +    // This constructor does a shallow copy of the passed-in SkBitmap (ie.,
it

Nit:  technically this is a function, or factory function, not a constructor.

> Source/WebCore/platform/graphics/skia/NativeImageSkia.h:61
> +    // This constructor does a shallow copy of the internal SkBitmap (ie.,
it

Nit:  same here.