[webkit-reviews] review denied: [Bug 111391] [WEBGL] Enable HALF_FLOAT_OES tests in chromium : [Attachment 195180] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 111391: [WEBGL] Enable HALF_FLOAT_OES tests in chromium
https://bugs.webkit.org/show_bug.cgi?id=111391

Attachment 195180: Patch
https://bugs.webkit.org/attachment.cgi?id=195180&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195180&action=review


Given today's announcement regarding the Chromium project, I'm not sure I
should review this patch. However, these changes look undesirable for any
WebKit port, so marking it r-.

> LayoutTests/fast/canvas/webgl/oes-texture-half-float-not-supported.html:144
> +    }

Moving this call here is the wrong thing to do. Instead, make sure finishTest()
is called on all of the other code paths in the test.

> LayoutTests/fast/canvas/webgl/oes-texture-half-float-not-supported.html:-154
> -	   "playing", function() { runTextureUploadTest(video); finishTest();
}, true);

This change, and the duplication of finishTest() as finish(), is undesirable.