[webkit-reviews] review granted: [Bug 113910] Don't try to set the exception port for server connections : [Attachment 196425] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 3 17:38:04 PDT 2013


Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 113910: Don't try to set the exception port for server connections
https://bugs.webkit.org/show_bug.cgi?id=113910

Attachment 196425: Patch
https://bugs.webkit.org/attachment.cgi?id=196425&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196425&action=review


> Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp:425
> +	      
m_clientRunLoop->dispatch(bind(&Connection::dispatchDidReceiveInvalidMessage,
this, decoder->messageReceiverName().toString(),
decoder->messageName().toString()));

Too bad you have to do this much to do the invalid message dance. Would be nice
if we could share a little more code with the other invalid message cases.


More information about the webkit-reviews mailing list