[webkit-reviews] review granted: [Bug 113909] Add comment to clarify isStackingContext() in RenderLayer.h : [Attachment 196423] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 3 16:43:53 PDT 2013


Elliott Sprehn <esprehn at chromium.org> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 113909: Add comment to clarify isStackingContext() in RenderLayer.h
https://bugs.webkit.org/show_bug.cgi?id=113909

Attachment 196423: Patch
https://bugs.webkit.org/attachment.cgi?id=196423&action=review

------- Additional Comments from Elliott Sprehn <esprehn at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196423&action=review


> Source/WebCore/rendering/RenderLayer.h:861
> +    //	from the StyleResolver code.

"Only stacking contexts have non-auto z-index because of code in
StyleResolver::adjustRenderStyle" might be nicer, either way mentioning
adjustRenderStyle is probably good. I also don't think we usually use Note: in
webcore, but I don't have a strong opinion on that.


More information about the webkit-reviews mailing list