[webkit-reviews] review canceled: [Bug 113898] Clean up the occlusion handler registration / unregistration code : [Attachment 196409] Patch v1

[bugzilla-daemon at webkit.org]

Kiran Muppala <cmuppala at apple.com> has canceled Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 113898: Clean up the occlusion handler registration / unregistration code
https://bugs.webkit.org/show_bug.cgi?id=113898

Attachment 196409: Patch v1
https://bugs.webkit.org/attachment.cgi?id=196409&action=review

------- Additional Comments from Kiran Muppala <cmuppala at apple.com>
static const OcclusionNotificationHandler occlusionNotificationHandlers[] = {
 156	{ WKOcclusionNotificationTypeApplicationBecameVisible,
applicationBecameVisible, "Application Became Visible" },
 157	{ WKOcclusionNotificationTypeApplicationBecameOccluded,
applicationBecameOccluded, "Application Became Occluded" },
 158	{ WKOcclusionNotificationTypeApplicationWindowModificationsStarted,
applicationWindowModificationsStarted, "Application Window Modifications
Started" },
 159	{ WKOcclusionNotificationTypeApplicationWindowModificationsStopped,
applicationWindowModificationsStopped, "Application Window Modifications
Stopped" },
 160};

Minor observation: The registration of visible notification used to precede the
occluded notification and the order was reversed for unregistration.  Just a
defensive style.  Since the order is now fixed, the log line can be replaced
with an ASSERT and eliminate the return statement entirely.