[webkit-reviews] review granted: [Bug 32292] Unable to focus on embedded plugins such as Flash via javascript focus() : [Attachment 196405] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Dave Michael
<dmichael at chromium.org>'s request for review:
Bug 32292: Unable to focus on embedded plugins such as Flash via javascript
focus()
https://bugs.webkit.org/show_bug.cgi?id=32292

Attachment 196405: Patch
https://bugs.webkit.org/attachment.cgi?id=196405&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196405&action=review


> Source/WebCore/html/HTMLPlugInElement.cpp:252
> +    if (HTMLFrameOwnerElement::supportsFocus())
> +	   return true;
> +
> +    if (useFallbackContent() || !renderer() ||
!renderer()->isEmbeddedObject())
> +	   return false;
> +    return
!toRenderEmbeddedObject(renderer())->showsUnavailablePluginIndicator();

OMG! This function is so self-evidently clear now.

> LayoutTests/plugins/focus-expected.txt:9
> +PASS "embedElem"; document.activeElement === pluginElement is true

I guess the old output was nice in that we could see what pluginElement is set
to but I guess it's obvious from the context.