[webkit-reviews] review denied: [Bug 113816] [BlackBerry] Adjustments to media controls appearance : [Attachment 196385] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 3 12:11:44 PDT 2013


Rob Buis <rwlbuis at gmail.com> has denied John Griggs <jgriggs at rim.com>'s request
for review:
Bug 113816: [BlackBerry] Adjustments to media controls appearance
https://bugs.webkit.org/show_bug.cgi?id=113816

Attachment 196385: Patch
https://bugs.webkit.org/attachment.cgi?id=196385&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196385&action=review


Please fix the ChangeLog.

> Source/WebCore/ChangeLog:3
> +	   2013-04-02  John Griggs  <jgriggs at blackberry.com>

Why the double author lines? One is enough.

> Source/WebCore/ChangeLog:8
> +	    - upstream some other cosmetic changes to media controls that were
not previously upstreamed.

This should be part of your commit message below, not the bug titles.


More information about the webkit-reviews mailing list