[webkit-reviews] review granted: [Bug 113831] get_by_pname can become confused when iterating over objects with static properties : [Attachment 196366] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 3 10:44:27 PDT 2013


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 113831: get_by_pname can become confused when iterating over objects with
static properties
https://bugs.webkit.org/show_bug.cgi?id=113831

Attachment 196366: Patch
https://bugs.webkit.org/attachment.cgi?id=196366&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196366&action=review


r=me

> LayoutTests/fast/js/dom-static-property-for-in-iteration-expected.txt:163
> +PASS true is true

This is a bit opaque.

> LayoutTests/fast/js/dom-static-property-for-in-iteration.html:18
> +		   var actual = a[i];
> +		   var expected = a["" + i];
> +		   shouldBeTrue(String(actual === expected));

You'll get better test output if you do something like this: shouldBe('a[i]',
'a["" + i]').


More information about the webkit-reviews mailing list