[webkit-reviews] review granted: [Bug 113845] Input value/placeholder is not redrawn when the input height grows : [Attachment 196282] Patch 2

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 113845: Input value/placeholder is not redrawn when the input height grows
https://bugs.webkit.org/show_bug.cgi?id=113845

Attachment 196282: Patch 2
https://bugs.webkit.org/attachment.cgi?id=196282&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196282&action=review


> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:257
> +	   innerTextRenderer->setNeedsLayout(true, MarkOnlyThis);

You shouldn't MarkOnlyThis. I'm trying to get rid of all of our uses of
MarkOnlyThis. There are a couple cases where we need it right now to avoid
hitting asserts, but setNeedsLayout in styleDidChange/styleWillChange it should
be safe to leave out the MarkOnlyThis.