[webkit-reviews] review granted: [Bug 113863] [Qt] Move logic of simple forwarding functions to TestRunner. : [Attachment 196315] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 3 03:45:55 PDT 2013


Simon Hausmann <hausmann at webkit.org> has granted Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 113863: [Qt] Move logic of simple forwarding functions to TestRunner.
https://bugs.webkit.org/show_bug.cgi?id=113863

Attachment 196315: Patch
https://bugs.webkit.org/attachment.cgi?id=196315&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196315&action=review


> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:833
> +    DumpRenderTree* drt = DumpRenderTree::instance();

Since what we need is the QWebPage and not the drt, you could also declare a
local QWebPage *webPage variable instead of *drt


More information about the webkit-reviews mailing list