[webkit-reviews] review granted: [Bug 113852] Refine LOG messages in WebSocket related components : [Attachment 196290] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Takeshi Yoshino
<tyoshino at google.com>'s request for review:
Bug 113852: Refine LOG messages in WebSocket related components
https://bugs.webkit.org/show_bug.cgi?id=113852

Attachment 196290: Patch
https://bugs.webkit.org/attachment.cgi?id=196290&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196290&action=review


> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:390
> +	   LOG(Network, "WebSocketChannel %p appendToBuffer Buffer overflow
(%lu bytes already in receive buffer and appending %lu bytes)", this,
static_cast<unsigned long>(m_buffer.size()), static_cast<unsigned long>(len));

appendToBuffer -> appendToBuffer() for consistency?

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:468
> +    LOG(Network, "WebSocketChannel %p startClosingHandshake code=%d
m_receivedClosingHandshake=%d", this, m_closing, m_receivedClosingHandshake);

startClosingHandshake -> startClosingHandshake() ?