[webkit-reviews] review granted: [Bug 113844] Remove code for Mac 10.5 and earlier from WTF and WebKit2 : [Attachment 196279] Cleanup

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 113844: Remove code for Mac 10.5 and earlier from WTF and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=113844

Attachment 196279: Cleanup
https://bugs.webkit.org/attachment.cgi?id=196279&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196279&action=review


> Source/WTF/wtf/Platform.h:673
>  #define HAVE_SYS_TIMEB_H 1
>  #define WTF_USE_ACCELERATE 1
>  
> -#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060
> -
>  #define HAVE_DISPATCH_H 1
>  #define HAVE_MADV_FREE 1
>  #define HAVE_PTHREAD_SETNAME_NP 1

Better re-order the #defines alphabetically with the ones above.

> Source/WebKit2/Shared/mac/PasteboardTypes.mm:48
>      static NSArray *types = retain([NSArray
arrayWithObjects:WebArchivePboardType, NSHTMLPboardType, NSFilenamesPboardType,
NSTIFFPboardType, NSPDFPboardType,
> -#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1050
> -	   NSPICTPboardType,
> -#endif
>	   NSURLPboardType, NSRTFDPboardType, NSRTFPboardType,
NSStringPboardType, NSColorPboardType, kUTTypePNG, nil]);
>      return types;

While you are at it, maybe clean the array allocation?

static NSArray *types = [[NSArray alloc] initWithArray: WebArchivePboardType,
NSHTMLPboardType, NSFilenamesPboardType, NSTIFFPboardType, NSPDFPboardType, etc