[webkit-reviews] review denied: [Bug 113845] Input value/placeholder is not redrawn when the input height grows : [Attachment 196278] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 22:41:00 PDT 2013


Ojan Vafai <ojan at chromium.org> has denied Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 113845: Input value/placeholder is not redrawn when the input height grows
https://bugs.webkit.org/show_bug.cgi?id=113845

Attachment 196278: Patch
https://bugs.webkit.org/attachment.cgi?id=196278&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196278&action=review


> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:256
> +    if (RenderObject* innerTextRenderer = innerTextElement()->renderer())
> +	   innerTextRenderer->setNeedsLayout(true, MarkOnlyThis);

I think we only need this if stye StyleDifference is a Layout difference.


More information about the webkit-reviews mailing list