[webkit-reviews] review granted: [Bug 113699] [ATK] build fails when accessibility is turned off : [Attachment 196187] Updated according to reviewer suggestions.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 21:30:13 PDT 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ed Bartosh
<bartosh at gmail.com>'s request for review:
Bug 113699: [ATK] build fails when accessibility is turned off
https://bugs.webkit.org/show_bug.cgi?id=113699

Attachment 196187: Updated according to reviewer suggestions.
https://bugs.webkit.org/attachment.cgi?id=196187&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196187&action=review


LGTM otherwise.

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:23
> +#if HAVE(ACCESSIBILITY)

It would be good if you add a new line below.

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:111
> +#endif // HAVE(ACCESSIBILITY)

It would be good if you add a new line above.


More information about the webkit-reviews mailing list